Update README.md to reflect the current situation #366
Conversation
| The current generator runs on with clang 3.8, but can also run with clang 3.9 | ||
| with more features (such as detection of inlined functions). | ||
| It is recommended to use clang 3.9 with the current generator. It can run with | ||
| clang 3.8 with some features unavailable. |
There was a problem hiding this comment.
Nit: "It can run with clang-3.8 with some features disabled"
| # Library usage with `build.rs` | ||
|
|
||
| See [the Stylo build script][stylo-script] to see how is it used inside the |
There was a problem hiding this comment.
Nit: "... how it is ..."
| ``` | ||
|
|
||
| To build with Clang 3.8, you need to append `--feature llvm_stable` in addition |
| options might exist (see [the SpiderMonkey script][sm-script] and [the Stylo | ||
| scripts][stylo-scripts] to see how is it used inside the Servo organisation. | ||
| options might exist (see [the SpiderMonkey script][sm-script] to see how is | ||
| it used inside the Servo organisation. |
There was a problem hiding this comment.
Nit: "... how it is ..."
| $ LIBCLANG_PATH=path/to/clang-3.9/build/lib \ | ||
| LD_LIBRARY_PATH=path/to/clang-3.9/build/lib \ | ||
| cargo build | ||
| $ export LIBCLANG_PATH=path/to/clang-3.9/lib |
There was a problem hiding this comment.
Not sure whether leaving LD_LIBRARY_PATH will have an effect (cc @emilio)
There was a problem hiding this comment.
Hmm, per description in clang-sys's README, it seems we would still need LD_LIBRARY_PATH.
| ``` | ||
|
|
||
| #### From source |
There was a problem hiding this comment.
Wouldn't hurt to have a note saying that people can also build it from source.
| ``` | ||
|
|
||
| To build with Clang 3.8, you need to append `--feature llvm_stable` in addition |
There was a problem hiding this comment.
This is not needed anymore, it's the same for any version of clang since we load it dinamically and check for symbols.
This feature is only needed for testing now, so feel free to remove this section.
|
@bors-servo delegate+ |
|
✌️ @upsuper can now approve this pull request |
There are several changes: * Announce that Clang 3.9 is the new default * Update the install steps for 3.9 * Add installing steps for Windows * Update stylo's usage of bindgen
upsuper
force-pushed
the
update-readme
branch
from
3d44a05 to
a65e825
Compare
|
@bors-servo r=emilio |
|
📌 Commit a65e825 has been approved by |
Update README.md to reflect the current situation There are several changes: * Announce that Clang 3.9 is the new default * Update the install steps for 3.9 * Add installing steps for Windows * Update stylo's usage of bindgen
|
☀️ Test successful - status-travis |
There are several changes: