Don't assume that base classes are already resolved. #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bunch of complexity we don't use nor need.
|
PSA stylo people (@heycam, @upsuper, @bholley, @Manishearth), this is likely to produce a more-noisy-than-usual bindings update, since we parse stuff in different order. But I've verified this doesn't break anything in stylo. |
fitzgen
approved these changes
Dec 23, 2016
| @@ -17,13 +18,13 @@ | |||
| #![allow(non_upper_case_globals)] | |||
|
|
|||
| #[macro_use] | |||
| #[allow(unused_extern_crates)] | |||
There was a problem hiding this comment.
It still warns here despite #[macro_use] and our macro usage?
There was a problem hiding this comment.
Yep, that's a known false positive from that lint.
|
@bors-servo r+ |
|
📌 Commit b93faf9 has been approved by |
|
⚡ Test exempted - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it may not be the case.
Fixes #359
Also fixes a few other test cases in the codebase that had the wrong namespace relationship.
r? @fitzgen