Multiple cleanups and fix for #355 #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Confirm that this fixes the problem I reported in #355 in the full source. |
fitzgen
approved these changes
Dec 22, 2016
| return self.codegen(ctx, result, _whitelisted_items, item); | ||
| }, | ||
| _ => panic!("How?") | ||
| _ => panic!("How did this end up here {:?}?", signature) |
There was a problem hiding this comment.
Soft preference for a more descriptive message here:
Signature's kind is not TypeKind::Function?! {:?}
| // Assume signedness since the default type by the C standard is an int. | ||
| let is_signed = repr | ||
| .and_then(|r| ctx.resolve_type(r).safe_canonical_type(ctx)) | ||
| .map_or(true, |ty| { |
| /// If this type has a known size, return it (in bytes). This is to | ||
| /// alleviate libclang sometimes not giving us a layout (like in the case | ||
| /// when an enum is defined inside a class with template parameters). | ||
| pub fn known_size(&self) -> Option<usize> { |
|
Updated the error message. @bors-servo r=fitzgen |
|
📌 Commit 1ad2821 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
Also improves the output of #354.
r? @fitzgen