Skip to content

Wrap Type into Option #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2016
Merged

Wrap Type into Option #347

merged 1 commit into from
Dec 15, 2016

Conversation

impowski
Copy link
Contributor

Fix #129

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@impowski
Copy link
Contributor Author

r? @fitzgen

fitzgen
fitzgen approved these changes Dec 15, 2016
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@fitzgen
Copy link
Member

fitzgen commented Dec 15, 2016

@bors-servo r+

@bors-servo
Copy link

📌 Commit 5417d97 has been approved by fitzgen

@bors-servo
Copy link

⚡ Test exempted - status

@bors-servo bors-servo merged commit 5417d97 into rust-lang:master Dec 15, 2016
bors-servo pushed a commit that referenced this pull request Dec 15, 2016
Auto merge of #347 - impowski:typedef_type_cleanup, r=fitzgen
64038c3 
Wrap Type into Option

Fix #129
@impowski impowski deleted the typedef_type_cleanup branch December 15, 2016 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@impowski @highfive @fitzgen @bors-servo