Add ignore_methods to bindgen #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, but I'm not a bindgen peer. r? @emilio |
|
@bors-servo: r+ |
|
📌 Commit 132a6fa has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Aug 13, 2016
Add ignore_methods to bindgen I'm defining a struct inline in ServoBindings.h via a macro (for the already_addrefed stuff), and I need to forbid its ignore_methods from getting generated without forbidding functions as well. r? @bholley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm defining a struct inline in ServoBindings.h via a macro (for the already_addrefed stuff), and I need to forbid its ignore_methods from getting generated without forbidding functions as well.
r? @bholley