Add support for elaborated types. #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edunham This repo is not reported to IRC or homu yet. Can you turn that on? |
|
So that's something that changed in libclang itself or something like that? |
bors-servo
pushed a commit
to servo/rust-mozjs
that referenced
this pull request
Jun 23, 2016
Fix linux 64bit bindings which included inline symbols This requires rust-lang/rust-bindgen#2 and rust-lang/rust-bindgen#3 to run bindgen, but does not need to wait on those to land as the new bindings are included here. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/271) <!-- Reviewable:end -->
| @@ -946,6 +952,9 @@ pub fn type_to_str(x: Enum_CXTypeKind) -> &'static str { | |||
| CXType_IncompleteArray => "IncompleteArray", | |||
| CXType_VariableArray => "VariableArray", | |||
| CXType_DependentSizedArray => "DependentSizedArray", | |||
| CXType_MemberPointer => "CXType_MemberPointer", | |||
| CXType_Auto => "CXType_Auto", | |||
| CXType_Elaborated => "CXType_Elaborated", | |||
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Jun 23, 2016
add servo/rust-bindgen as Jack requested in rust-lang/rust-bindgen#3 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/402) <!-- Reviewable:end -->
Merged
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Jun 23, 2016
add servo/rust-bindgen as Jack requested in rust-lang/rust-bindgen#3 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/402) <!-- Reviewable:end -->
|
@emilio re-r? |
|
r+, I'm looking into CI issues right now (#5) that should allow us to autoland this instead of merging manually, but feel free to do so. |
|
@bors-servo: r+ |
|
📌 Commit 1c4ca74 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 30, 2016
Add support for elaborated types. Things like JS::Latin1Char now show up as elaborated types and we need to use clang_Type_getNamedType to resolve them. This should fix #1.
|
💔 Test failed - travis |
|
☔ The latest upstream changes (presumably #6) made this pull request unmergeable. Please resolve the merge conflicts. |
bors-servo
pushed a commit
that referenced
this pull request
Oct 29, 2016
After the rewrite, this works. Fixes #3
luser
pushed a commit
to luser/rust-bindgen
that referenced
this pull request
Mar 27, 2017
Reduce some nesting in cstruct_to_rs.
Merged
benesch
pushed a commit
to benesch/rust-bindgen
that referenced
this pull request
Dec 23, 2021
…bute Add attribute for C++ special members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things like JS::Latin1Char now show up as elaborated types and we need to use clang_Type_getNamedType to resolve them.
This should fix #1.