Skip to content

Trace function signature types #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Nov 21, 2016

This extends the TypeCollector trait implementation for Item to
consider items of kind Function and to collect the types found in the
function's signature.

Fixes #291

r? @emilio

#![allow(non_snake_case)]



Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er wait woops

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh

This extends the `TypeCollector` trait implementation for `Item` to
consider items of kind `Function` and to collect the types found in the
function's signature.

Fixes rust-lang#291
@fitzgen fitzgen force-pushed the type-referenced-by-whitelisted-function branch from fc6bd9f to bd29a7a Compare November 21, 2016 22:37
@fitzgen
Copy link
Member Author

fitzgen commented Nov 21, 2016

Fixed bad test case.

@emilio
Copy link
Contributor

emilio commented Nov 21, 2016

@bors-servo r+

Thanks!

@bors-servo
Copy link

📌 Commit bd29a7a has been approved by emilio

@bors-servo
Copy link

⚡ Test exempted - status

@bors-servo bors-servo merged commit bd29a7a into rust-lang:master Nov 21, 2016
bors-servo pushed a commit that referenced this pull request Nov 21, 2016
… r=emilio

Trace function signature types

This extends the `TypeCollector` trait implementation for `Item` to
consider items of kind `Function` and to collect the types found in the
function's signature.

Fixes #291

r? @emilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants