Do not evaluate variadic template types #284
Conversation
|
|
fitzgen
force-pushed
the
dont-eval-variadic-templates
branch
from
04384c3 to
80ac773
Compare
|
Rebased and fixed the merge conflict :) |
fitzgen
force-pushed
the
dont-eval-variadic-templates
branch
from
80ac773 to
e3649e2
Compare
This is a workaround for an internal clang assertion that gets triggered if we try to evaluate a variadic template type reference. Fixes rust-lang#283
fitzgen
force-pushed
the
dont-eval-variadic-templates
branch
from
e3649e2 to
1c18ec7
Compare
| // `CXType_Unexposed` from evaluation. | ||
| let mut found_cant_eval = false; | ||
| cursor.visit(|c| { | ||
| if c.kind() == CXCursor_TypeRef && c.cur_type().kind() == CXType_Unexposed { |
There was a problem hiding this comment.
FWIW I don't think recursing here is needed given the callers. Probably something like:
if cursor.semantic_parent().kind() == CXCursor_ClassTemplateCould be enough for our use case, but anyway it's fine.
Please add in the comment the issue number, and add a comment in new saying that this could be relatively expensive to call if mis-called.
r=me in any case. Thanks!
There was a problem hiding this comment.
The semantic parent ends up being a CXCursor_VarDecl and then that cursor's semantic parent is a CXCursor_ClassTemplate. I think the existing check is probably better than looking for a VarDecl -> ClassTemplate inheritence, although neither is satisfying.
|
@bors-servo r=emilio |
|
📌 Commit 1c18ec7 has been approved by |
|
☀️ Test successful - status-travis |
This is a workaround for an internal clang assertion that gets triggered
if we try to evaluate a variadic template type reference.
Fixes #283
r? @emilio