ir: Avoid generating out-of-range values in constants. #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsuper
reviewed
Nov 17, 2016
| @@ -9,6 +9,9 @@ pub const bar: _bindgen_ty_1 = _bindgen_ty_1::bar; | |||
| #[repr(u32)] | |||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)] | |||
| pub enum _bindgen_ty_1 { foo = 4, bar = 8, } | |||
| pub type EasyToOverflow = ::std::os::raw::c_ulonglong; | |||
| pub const k: EasyToOverflow = 2147483648; | |||
| pub const k_expr: EasyToOverflow = 0; | |||
There was a problem hiding this comment.
This doesn't seem to be desirable. Build would succeed, but existence of this may lead to weird bug. This should either be removed, or be linked.
There was a problem hiding this comment.
We're getting zero from clang in this case unfortunately, so there's little I can do :(
fitzgen
approved these changes
Nov 17, 2016
| if val.is_none() || !kind.signedness_matches(val.unwrap()) { | ||
| let tu = ctx.translation_unit(); | ||
| val = get_integer_literal_from_cursor(&cursor, tu); | ||
| } |
There was a problem hiding this comment.
I slightly preferred all this with the slightly more concise method chaining, but either way works.
There was a problem hiding this comment.
Yeah, it was a bit trickier to write it that way, because we may be overriding a Some(value out of range) with None, so I preferred to be more explicit.
|
@bors-servo r=fitzgen |
|
📌 Commit 06e5f6c has been approved by |
|
⚡ Test exempted - status |
luser
pushed a commit
to luser/rust-bindgen
that referenced
this pull request
Mar 27, 2017
This completely disables translation of C enums to Rust enums, restoring to the old behaviour of translating them to integer constants.
luser
pushed a commit
to luser/rust-bindgen
that referenced
this pull request
Mar 27, 2017
Introduce -no-rust-enums (fixes rust-lang#276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #274 until my patch or a similar one gets accepted and we can use it.
r? @fitzgen or @upsuper