Use prettyplease to format expectations
#2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces `rustfmt` by `prettyplease` as the used formatter for the expectation tests. This was done because we currently rely on the nightly version of `rustfmt` which recently broke our test suite by changing how code in macros is formatted. The `prettyplease` crate does not have that issue because we are using a specific version in the Cargo manifest.
pvdrz
force-pushed
the
prettyplease-in-tests
branch
from
d75859f to
554ff6b
Compare
tshepang
reviewed
May 24, 2023
pvdrz
force-pushed
the
prettyplease-in-tests
branch
from
dc9226c to
02e1ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
rustfmtbyprettypleaseas the used formatter for the expectation tests.This was done because we currently rely on the nightly version of
rustfmtwhich recently broke our test suite by changing how code in macros is formatted. Theprettypleasecrate does not have that issue because we are using a specific version in the Cargo manifest.