Skip to content

codegen: Always implement debug for __BindgenUnionField. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2016

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Nov 13, 2016

Our debug-detection code assumes so.

Fixes #246

r? @fitzgen

@emilio
Copy link
Contributor Author

emilio commented Nov 13, 2016

@bors-servo delegate=fizgen

@bors-servo
Copy link

✌️ @fizgen can now approve this pull request

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fitzgen
Copy link
Member

fitzgen commented Nov 14, 2016

@bors-servo r+

@fitzgen fitzgen closed this Nov 14, 2016
@fitzgen fitzgen reopened this Nov 14, 2016
@fitzgen
Copy link
Member

fitzgen commented Nov 14, 2016

@bors-servo r+

@fitzgen
Copy link
Member

fitzgen commented Nov 14, 2016

@emilio you did delegate "fizgen" not "fitzgen", so I can't approve.

@emilio
Copy link
Contributor Author

emilio commented Nov 14, 2016

Yikes, sorry :/

@bors-servo r=fitzgen

@bors-servo
Copy link

📌 Commit 89ee7e0 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 89ee7e0 with merge e20f4c9...

bors-servo pushed a commit that referenced this pull request Nov 14, 2016
codegen: Always implement debug for __BindgenUnionField.

Our debug-detection code assumes so.

Fixes #246

r? @fitzgen
@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 89ee7e0 into rust-lang:master Nov 14, 2016
@emilio emilio deleted the union-debug-again branch November 14, 2016 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants