Handle macro redefinition a bit more graciously. #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo delegate=fitzgen |
|
✌️ @fitzgen can now approve this pull request |
fitzgen
approved these changes
Nov 14, 2016
| #![allow(non_snake_case)] | ||
|
|
||
|
|
||
| pub const FOO: ::std::os::raw::c_uint = 4; |
There was a problem hiding this comment.
Ideally, FOO would be 5 in the bindings. We want the last definition, not the first.
Also, file a follow up issue to track not generating bindings for macros that have been #undefed.
|
@bors-servo r+ |
|
📌 Commit 1001e3b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 14, 2016
Handle macro redefinition a bit more graciously. r? @fitzgen
|
☀️ Test successful - status-travis |
luser
pushed a commit
to luser/rust-bindgen
that referenced
this pull request
Mar 27, 2017
Translate C enums to Rust enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @fitzgen