Update to clap 4. #2380
Update to clap 4. #2380
Conversation
|
Hi @qwandor thanks for you PR! Is some functionality missing from the current version of clap that you need? I'm a bit reluctant (but open) to raise the MSRV for bindgen because of this change |
|
Hi, sorry, I've added a description. The context in my case is that I'm working on Android, where we vendor all dependencies into our tree, and require that there is only a single version of each crate. We would like to update to clap 4, as the latest version of a number of other crates that we use depend on it, and would also like to use some features from it in our own code. However, we also use bindgen, which currently still depends on clap 3, which is blocking the update. I could patch bindgen downstream in our vendored version, but given the relatively large number of changes that's going to make maintenance a real pain, so I'd much rather get this update in upstream if possible. |
|
Oh ok yeah, that sounds like a hassle. I'm not sure but maybe we can raise the MSRV for I'll try to figure out something so we can merge this ASAP. |
|
Thanks! We are using |
huh, interesting. So you actually need to pull the |
|
Right, you can see it here if you're curious. |
|
☔ The latest upstream changes (presumably 5875949) made this pull request unmergeable. Please resolve the merge conflicts. |
Done. |
| .multiple_occurrences(true), | ||
| .action(ArgAction::SetTrue), |
There was a problem hiding this comment.
Ah! this is neat. It seems we were using multiple_occurrences incorrectly. Thank you! ❤️
|
r+ |
Most other crates (including
cxx) use clap 4 by now, and bindgen using clap 3 results in multiple versions needing to be maintained in projects which vendor dependencies.