ir: Search for compound structures when we have unexposed type and base class cursor. #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo delegate=fitzgen |
|
✌️ @fitzgen can now approve this pull request |
…se class cursor. And it's not a valid identifier as a template parameter. See the comment and the tests for details.
emilio
force-pushed
the
js-madness
branch
2 times, most recently
from
84fb934 to
5e41fb9
Compare
|
@bors-servo r+ |
|
📌 Commit 5e41fb9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 11, 2016
ir: Search for compound structures when we have unexposed type and base class cursor. And it's not a valid identifier as a template parameter. See the comment and the tests for details. Better ideas for the check appreciated, but I was really sleepy to look for a better solution right now. r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And it's not a valid identifier as a template parameter. See the comment and the
tests for details.
Better ideas for the check appreciated, but I was really sleepy to look for a better solution right now.
r? @fitzgen