Skip to content

Allow callback composition #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Nov 2, 2022

Store all the callbacks added to the builder in a Vec so bindgen invokes each one of them in a last-to-first manner.

Store all the callbacks added to the builder in a `Vec` so bindgen
invokes each one of them in a last-to-first manner.
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you document this in the changelog? r=me in any case.

@pvdrz
Copy link
Contributor Author

pvdrz commented Nov 2, 2022

@bors-servo r=emilio

@bors-servo
Copy link

@pvdrz: 🔑 Insufficient privileges: Not in reviewers

@emilio
Copy link
Contributor

emilio commented Nov 2, 2022

@bors-servo r+

@bors-servo
Copy link

📌 Commit 441bc85 has been approved by emilio

@pvdrz pvdrz merged commit a673a6b into rust-lang:master Nov 2, 2022
@pvdrz pvdrz deleted the multi-parse-callbacks branch November 2, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants