Skip to content

Add tutorial about non-system libraries #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Oct 21, 2022

fixes #1299

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to generally point just at how linking external libs (and point out that bindgen doesn't build or link them). But a minimal example with something like:

cc::Build::new()
.cpp(true)
.file("cpp/Test.cc")
.include("include")
.compile("libtest.a");

which is all that's needed to build + link a simple c/c++ file, would probably be ok.

@emilio
Copy link
Contributor

emilio commented Oct 22, 2022

(CI is failing, due to the broken comment above)

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that's fair.

@pvdrz pvdrz merged commit 4f92dfb into rust-lang:master Nov 1, 2022
@pvdrz pvdrz deleted the non-system-libraries branch November 1, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No recommended practices for non-system libraries
2 participants