Skip to content

Add --newtype-global-enum option #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2022
Merged

Add --newtype-global-enum option #2270

merged 1 commit into from
Sep 11, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 9, 2022

Fixes: #2232

@pvdrz pvdrz requested review from emilio and kulp September 9, 2022 21:38
kulp
kulp approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@kulp kulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fit nicely.

Based on #2232 (comment) I will merge this in a few days if @emilio does not see a problem before then.

@kulp
Copy link
Member

kulp commented Sep 11, 2022

I looked for other places in documentation that we might need to update (including in book/src) but I did not find any.

Thanks!

@kulp kulp merged commit 61636e9 into rust-lang:master Sep 11, 2022
@pvdrz pvdrz mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulp kulp kulp approved these changes

@emilio emilio Awaiting requested review from emilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newtype enums but with global constants
2 participants
@pvdrz @kulp