Add clang::Type::is_valid and use it instead of checking self.kind() against CXType_Invalid
#224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A helper for checking if the type's kind is not `CXType_Invalid`.
|
r=me, though you probably want to drop the first commit or close #223, because otherwise they're going to conflict. @bors-servo delegate+ |
|
✌️ @fitzgen can now approve this pull request |
Why would they conflict? This is on top of that commit. |
|
@bors-servo r=emilio |
|
📌 Commit d5ee20c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 8, 2016
Add `clang::Type::is_valid` and use it instead of checking self.kind() against CXType_Invalid Needed `is_valid()` when debugging, so figured we should land this and update places where we compare against the magical sentinel value. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed
is_valid()when debugging, so figured we should land this and update places where we compare against the magical sentinel value.r? @emilio