Speed up integration tests (move building expectations) #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This looks good, but needs documentation, and being added to CI. |
Speed up running 'cargo test': -Before: 2'17s -After: 30s Update to use new path: Makefile, .travis.yml, CONTRIBUTING.md, tests/tests.rs Delete unused expectation that fail to compile: tests/expectations/moar_bitfields.rs tests/expectations/variadic_template_args.rs For every 'cargo test' run, the bindgen output where built. We already test that the bindgen output match expectations/*.rs, so there is no need to check it build unless the expectation is updated. Move tests/expectations/*.rs to tests/expectations/tests/*.rs and make tests/expectations a new dev-dependency package. This allow running: - cargo test -p tests_expectations In addition to the speed up, we also get a clean output for the build and test run. In particular, a number of warnings are generated that should probably be silenced, and eventually enforced modifying travis to build: - RUSTFLAGS='-D warnings' cargo test -p tests_expectations The benefit of having it as a new package is that it avoid polluting the 'cargo test' output that should focus on bindgen.
jeanphilippeD
force-pushed
the
test_move_to_subpackage
branch
from
497ae94 to
2866ab5
Compare
|
Thank you very much for your review. I've updated all the places I found that mentioned expectations. |
|
@bors-servo r+ Looks good, thanks! |
|
📌 Commit 2866ab5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 6, 2016
Speed up integration tests (move building expectations) Speed up running 'cargo test': -Before: 2'17s -After: 30s Update to use new path: Makefile, .travis.yml, CONTRIBUTING.md, tests/tests.rs Delete unused expectation that fail to compile: tests/expectations/moar_bitfields.rs tests/expectations/variadic_template_args.rs
|
☀️ Test successful - status-travis |
|
Hmm, I'm working on #204, and having trouble running these tests on Windows. I've made sure Rust's https://gist.github.com/jdub/66752599b85d73b15d12a7d7fd985959 Works fine on Linux. And this is a cool change! |
|
Hello, Is it different when using Does the link error occurs as well when you do: |
|
Yeah, same error. Don't worry too much -- none of this was expected to work on Windows, and it's almost certainly an installation problem. Thanks. btw, between your changes and mine, we've reduced test suite time (excluding build) on my machine from about 21s to 2s. 😆 😆 😆 |
|
I bet it's not an installation problem, but that rustc may not be performing dead code elimination, which is what could cause those linker errors. EDIT: gcc which is the linker you're using, not rustc directly, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up running 'cargo test':
-Before: 2'17s
-After: 30s
Update to use new path:
Makefile, .travis.yml, CONTRIBUTING.md, tests/tests.rs
Delete unused expectation that fail to compile:
tests/expectations/moar_bitfields.rs
tests/expectations/variadic_template_args.rs