Drop support for clang <4.0 #2155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we delete a workaround that is no longer needed.
kulp
force-pushed
the
deprecate-clang-3-9
branch
from
321340a to
111c09b
Compare
kulp
commented
Feb 2, 2022
| @@ -7,16 +7,13 @@ This page lists the requirements for running `bindgen` and how to get them. | |||
| `bindgen` leverages `libclang` to preprocess, parse, and type check C and C++ | |||
| header files. | |||
|
|
|||
| It is recommended to use Clang 3.9 or greater, however `bindgen` can run with | |||
| It is recommended to use Clang 4.0 or greater, however `bindgen` can run with | |||
There was a problem hiding this comment.
@emilio, is it correct and helpful to continue to reference older-than-4.0 versions of Clang here ?
There was a problem hiding this comment.
Probably not much, also pretty much everyone should have newer clang at this point.
emilio
approved these changes
Feb 18, 2022
kulp
added a commit
to kulp/rust-bindgen
that referenced
this pull request
Feb 20, 2022
This should have been added in rust-lang#2155 but was missed then.
emilio
pushed a commit
that referenced
this pull request
Mar 15, 2022
This should have been added in #2155 but was missed then.
aatifsyed
pushed a commit
to aatifsyed/rust-bindgen
that referenced
this pull request
Sep 22, 2022
This should have been added in rust-lang#2155 but was missed then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vein of #1807, the current PR removes
bindgen's support for Clang 3.9. After this PR, the minimum Clang version supported is 4.0, which was released on 13 Mar 2017.This PR follows on from #1830, which removed support for versions prior to Clang 3.9. The current PR also cleans up some things that should have been caught when support for Clang <3.9 was removed.