Add --allowlist-file option #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emilio
requested changes
Dec 6, 2021
src/ir/context.rs
Outdated
| @@ -2318,6 +2319,21 @@ If you encounter an error missing from this list, please file an issue or a PR!" | |||
| return true; | |||
| } | |||
|
|
|||
| // Items with a source location in an explicitly allowlisted file | |||
| // are always included. | |||
| if let Some(location) = &item.location() { | |||
There was a problem hiding this comment.
That way you can remove this ampersand.
|
This branch is working great for openssl-sys :) sfackler/rust-openssl#1573 |
|
Is this ready to land? |
Yes, as far as I know – @emilio, anything else needed/wanted? |
|
☔ The latest upstream changes (presumably be6d07a) made this pull request unmergeable. Please resolve the merge conflicts. |
daviddrysdale
force-pushed
the
allowlist-file
branch
2 times, most recently
from
80de9c7 to
45bf83d
Compare
|
We are trying to use this feature in https://github.com/ianks/rb-sys for official Ruby support for Rust. Would love to see this get merged! |
daviddrysdale
force-pushed
the
allowlist-file
branch
from
45bf83d to
722f88e
Compare
|
@emilio i believe this should be ready to merge |
|
Any chance you could cut a release with this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.