Dangling item id in partial specializations #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a temporary binding for the newly allocated id so that we can use it in conditional breakpoints when debugging dangling `ItemId` references. I believe that we will want the ability to set conditional breakpoints in this method every single time we end up debugging dangling references, so it is worth landing in master.
|
Looks good to me, just one question. If you could add a test for this, that'd be neat. r=me, ideally with test (I'd look into specifying something like |
|
@bors-servo delegate+ |
|
✌️ @fitzgen can now approve this pull request |
emilio
reviewed
Nov 4, 2016
| // this type, so if we pass `with_id` as the parent, it is | ||
| // potentially a dangling reference. Instead, use the canonical | ||
| // template declaration as the parent. It is already parsed and | ||
| // has a known-resolvable `ItemId`. |
There was a problem hiding this comment.
I think this comment is not as accurate as it should. This ends up unused if we peek the early return in line 555 (the one with the error! thing, it's not about finding other type that is the same.
…ldren The `with_id` id will potentially end up unused if we find we already have an item (with its own distinct `ItemId`) for the type, so if we pass `with_id` as the parent id when parsing children it is potentially a dangling reference. Instead, use the canonical template declaration as the parent. It is already parsed and has a known-resolvable `ItemId`.
fitzgen
force-pushed
the
dangling-item-id-in-partial-specializations
branch
from
abb3cd5 to
d14b602
Compare
|
@bors-servo r=emilio I tried creating a test case, but couldn't build one that triggered this behavior :-/ |
|
📌 Commit d14b602 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 4, 2016
…ons, r=emilio Dangling item id in partial specializations See individual commit messages for details. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
r? @emilio