Skip to content

Fix Debug not being derived for Rust enumerations anymore by default #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

VeaaC
Copy link
Contributor

@VeaaC VeaaC commented Aug 3, 2021

bindgen used to derive Debug by default for all rustified enumerations, even if no-derive-debug was specified. This change restores that behaviour.

Fixes #2076

@VeaaC
Copy link
Contributor Author

VeaaC commented Aug 3, 2021

While looking into this I noticed that annotations on enumerations are mostly ignored (nodebug, additional derives, etc)

@VeaaC
Copy link
Contributor Author

VeaaC commented Aug 3, 2021

This is a minimal fix, a more comprehensive one that also enables the use of annotations on enumeration is #2090

@emilio
Copy link
Contributor

emilio commented Aug 24, 2021

Superceded by #2090.

@emilio emilio closed this Aug 24, 2021
@bors-servo
Copy link

☔ The latest upstream changes (presumably cf6edbd) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--no-derive-debug prevents even manual Debug on enumerations
4 participants