Allow aliases and template aliases to be considered for replacement #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Nov 3, 2016
| @@ -320,23 +320,28 @@ impl<'ctx> BindgenContext<'ctx> { | |||
| let mut replacements = vec![]; | |||
|
|
|||
| for (id, item) in self.items.iter() { | |||
| // Calls to `canonical_name` are expensive, so eagerly filter out | |||
| // items that cannot be replaced. | |||
|
|
|||
There was a problem hiding this comment.
nit: this newline may be removed
| continue; | ||
| match *ty.kind() { | ||
| TypeKind::Comp(ref ci) if !ci.is_template_specialization() => {} | ||
| TypeKind::TemplateAlias(_, _) => {} |
There was a problem hiding this comment.
nit: Maybe TypeKind::TemplateAlias(_, _) | TypeKind::Alias(_, _) => {}?
fitzgen
force-pushed
the
replace-template-alias
branch
from
124b7ca to
8041ebf
Compare
|
Fixed nits! |
|
@bors-servo r+ Thanks! |
|
📌 Commit 8041ebf has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2016
Allow aliases and template aliases to be considered for replacement Fixes #89. I'm not exactly *happy* with the way this is implemented (making `real_canonical_name` public so that we can use it in replacement lookups) but I'm not sure of a better way without refactoring most of how naming works right now. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.
I'm not exactly happy with the way this is implemented (making
real_canonical_namepublic so that we can use it in replacement lookups) but I'm not sure of a better way without refactoring most of how naming works right now.r? @emilio