clang: Simplify visiting code. #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@bors-servo delegate=fitzgen |
|
✌️ @fitzgen can now approve this pull request |
fitzgen
approved these changes
Nov 3, 2016
| @@ -306,18 +298,13 @@ impl Cursor { | |||
| /// Call the given function on each AST node traversed. See `CursorVisitor` | |||
There was a problem hiding this comment.
There is no long a CursorVisitor to go see the comments for. We should delete that part of the comment.
It has always been a mess.
|
@bors-servo r=fitzgen |
|
📌 Commit 3fa7228 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2016
clang: Simplify visiting code. It has always been a mess. r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has always been a mess.
r? @fitzgen