Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch based on [Close #961] Add --no-debug flag #1190, thanks ivanovaleksey
Add
--no-debug <regex>
andBuilder::no_debug(String)
to supply regexes for matching against types that we should not derive or implementDebug
for.Adding this feature involves:
RegexSet
member tobindgen::Builder
(similar to thewhitelisted_types
set).Builder
method to add strings to thatRegexSet
.src/options.rs
to convert--no-debug <regex>
CLI flags into invocations of the builder method.MonotoneFramework::constrain
function insrc/ir/analysis/derive_debug.rs
check if the given item is explicitly marked not to beDebug
, and if so, inserting it into theself.cannot_derive_debug
set viareturn self.insert(id)
.Debug
insrc/codegen/derive_debug.rs
so that we don't generate animpl Debug for ... for
these types when--impl-debug
is passed.--impl-debug
is also supplied--impl-debug
is not also supplied