Added Bindgen names to objective-c pointer return types for #1835. #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
simlay
force-pushed
the
add_bindgen_names_for_objc_pointers
branch
from
0e88711 to
6ffbdef
Compare
emilio
approved these changes
Aug 3, 2020
emilio
force-pushed
the
add_bindgen_names_for_objc_pointers
branch
from
6ffbdef to
22fa828
Compare
|
I rebased and addressed my nit, I'll merge once CI is back green. Thanks again for the fix! |
simlay
commented
Aug 5, 2020
src/codegen/mod.rs
Outdated
| @@ -3466,6 +3466,9 @@ impl TryToRustTy for Type { | |||
| inner.into_resolver().through_type_refs().resolve(ctx); | |||
| let inner_ty = inner.expect_type(); | |||
|
|
|||
| let is_objc_pointer = | |||
| matches!(inner_ty.kind(), TypeKind::ObjCInterface(..)); | |||
There was a problem hiding this comment.
@emilio This is much cleaner but wasn't added until 1.42 and the minimum supported Rust version is 1.34.. Thoughts?
There was a problem hiding this comment.
Oh, d'oh, I thought that we were using the matches crate already... Sure, then let's make this just a plain match :)
This was referenced Aug 6, 2020
simlay
force-pushed
the
add_bindgen_names_for_objc_pointers
branch
from
22fa828 to
7ee6eb6
Compare
* Took advantage of the repr transparent to use Bindgen return type names. * Updated unit tests and book
simlay
force-pushed
the
add_bindgen_names_for_objc_pointers
branch
from
834014f to
1431f2d
Compare
emilio
approved these changes
Aug 15, 2020
| @@ -3466,6 +3466,14 @@ impl TryToRustTy for Type { | |||
| inner.into_resolver().through_type_refs().resolve(ctx); | |||
| let inner_ty = inner.expect_type(); | |||
|
|
|||
| let is_objc_pointer = | |||
| inner.kind().as_type().map_or(false, |ty| { | |||
There was a problem hiding this comment.
You can use inner_ty here, which is just a type already, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1835.
This change seems too easy and really only works because the generated
structsare#[repr(transparent)].I tested it with UIKit in my iced branch, and this is the changeset.
I also added some more documentation to highlight this change. Rendered.
Also, I'd like to mention that this is definitely a breaking change to any crates that take advantage of the objective-c generated bindings. After a little bit of searching on crates.io, I can't really find any published crates that do this. Perhaps I'm the only one?