Fix #121: Cursor::num_template_args(...) returns Option<u32> instead of c_int #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of c_int
|
|
emilio
approved these changes
Nov 1, 2016
| @@ -192,7 +197,8 @@ impl Cursor { | |||
| /// Is the referent a fully specialized template specialization without any | |||
| /// remaining free template arguments? | |||
| pub fn is_fully_specialized_template(&self) -> bool { | |||
| self.is_template() && self.num_template_args() > 0 | |||
| self.is_template() && self.num_template_args() | |||
| .expect("Not a class template specialization") > 0 | |||
There was a problem hiding this comment.
can you call unwrap directly? It's clear from the backtrace what the failure is.
There was a problem hiding this comment.
Ok will do the change, thanks for the feedback
|
Thanks for doing this, that was fast! :) |
|
@bors-servo r+ |
|
📌 Commit 664786a has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Nov 1, 2016
Fix #121: Cursor::num_template_args(...) returns Option<u32> instead of c_int Now, functions calling Cursor::num_template_args() call expect() on the return value to make sure it is a valid value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, functions calling Cursor::num_template_args() call expect() on the return value to make sure it is a valid value