Use a consistent style everywhere.

[emilio]

r? @fitzgen

[highfive]

Warning

• These commits modify unsafe code. Please review it carefully!

[emilio]

@bors-servo delegate=fitzgen

[emilio]

I'm still unsure about the "run it on CI" thing. It's nice but it seems it can be pretty annoying for new contributors. I'd say it's worth trying, but if we see too many people getting stuck with it, we can back it out.

[fitzgen]

AWESOME!!

I was going to bring this up soon, and I actually accidentally rustfmted some files locally because of key chord habits in my editor :P

Taking a look now...

[fitzgen]

I'm still unsure about the "run it on CI" thing. It's nice but it seems it can be pretty annoying for new contributors. I'd say it's worth trying, but if we see too many people getting stuck with it, we can back it out.

The other thing is, if we have different versions of rustfmt installed, they can end up formatting the code differently. I've run into this with gimli, where we decided that it was not worth it to put in CI.

Soft -1 about running in CI.

Ideally, bors or highfive or whoever would automatically run rustfmt after every merge, and if there was any change, then automatically merge a rustfmt commit. Best of both worlds: we don't bounce new contributors and we always end up with a styled master.

[emilio]

@fitzgen sounds good, I'll drop the CI commit. Meanwhile we can run it manually I guess.

[fitzgen]

Awesome :)

[fitzgen]

Soft -1 if this is going to cause travis CI to fail if there is any difference in the formatting. As mentioned before, we will hit this issue with different rustfmt versions.

[fitzgen]

Maybe put this after testing? I feel like learning about testing is more important for newcomers.

[emilio]

Yup, agreed! Done :)

[fitzgen]

@bors-servo r+

[emilio]

For some reason bors didn't listen to me initially. Meh.

@bors-servo r=fitzgen

[emilio]

Reopened as #183, given homu was ignoring this one.