Skip to content

Fix for #138 : rework for elem_type() which now returns Option<Type> instead of Type #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

Incognitas
Copy link

Fixes #138
Since I am new to Rust, I hope I didn't do things too badly

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fitzgen
Copy link
Member

fitzgen commented Oct 31, 2016

r? @emilio care to rubber stamp?

@emilio
Copy link
Contributor

emilio commented Nov 1, 2016

@bors-servo r=fitzgen

Thanks for doing this!

@bors-servo
Copy link

📌 Commit 24bb8e1 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 24bb8e1 with merge daa9ab7...

bors-servo pushed a commit that referenced this pull request Nov 1, 2016
Fix for #138 : rework for elem_type() which now returns Option<Type> instead of Type

Fixes #138
Since I am new to Rust, I hope I didn't do things too badly
@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 24bb8e1 into rust-lang:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants