Move the TypeCollector trait to the ir module
#177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. There's a typo in the commit message (This commit move -> this commit moves). r=me apart from that. |
|
@bors-servo delegate+ |
|
✌️ @fitzgen can now approve this pull request |
This commit moves the `TypeCollector` trait out from the `codegen` module and into its own submodule in `ir::type_collector`. Additionally, it puts the various `TypeCollector` trait implementations next to the types that each implementation is for.
fitzgen
force-pushed
the
move-type-collector
branch
from
d87cf47 to
005fd43
Compare
|
@bors-servo r=emilio |
|
📌 Commit 005fd43 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 31, 2016
Move the `TypeCollector` trait to the `ir` module This commit move the `TypeCollector` trait out from the `codegen` module and into its own submodule in `ir::type_collector`. Additionally, it puts the various `TypeCollector` trait implementations next to the types that each implementation is for. I'm going to start using this trait outside of codegen, and I think it makes more sense in `ir` since it is implemented by `ir` types and is all about `ir` things. r? @emilio
|
Thanks! Fixed the typo :) |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit move the
TypeCollectortrait out from thecodegenmodule and into its own submodule inir::type_collector. Additionally, it puts the variousTypeCollectortrait implementations next to the types that each implementation is for.I'm going to start using this trait outside of codegen, and I think it makes more sense in
irsince it is implemented byirtypes and is all aboutirthings.r? @emilio