clang::Type::template_args return Option<TypeTemplateArgIterator> #175
+48
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emilio
approved these changes
Oct 31, 2016
|
|
||
| impl ExactSizeIterator for TypeTemplateArgIterator { | ||
| fn len(&self) -> usize { | ||
| if self.index < self.length { |
There was a problem hiding this comment.
self.index can never be greater than self.length right? In that case, this if is not needed, since we'll always return the correct value.
There was a problem hiding this comment.
Or an assert!(self.index <= self.length)
fitzgen
requested changes
Oct 31, 2016
| /// template arguments. Otherwise, return None. | ||
| pub fn num_template_args(&self) -> Option<u32> { | ||
| pub fn template_args(&self) -> Option<TypeTemplateArgIterator> | ||
| { |
There was a problem hiding this comment.
Nitpick: { on same line as the signature.
| @@ -747,6 +741,36 @@ impl Type { | |||
| } | |||
| } | |||
|
|
|||
| /// An iterator for a type's template arguments | |||
There was a problem hiding this comment.
Nitpick: add a period at the end of the sentence.
| let args = arg_types | ||
| .filter(|t| t.kind() != CXType_Invalid) | ||
| .map(|t| Item::from_ty_or_ref(t, None, None, ctx)) | ||
| .collect::<Vec<_>>(); |
| let n = unsafe { clang_Type_getNumTemplateArguments(self.x) }; | ||
| if n >= 0 { | ||
| Some(n as u32) | ||
| Some(TypeTemplateArgIterator { x: self.x, length: n as u32, index: 0 }) |
There was a problem hiding this comment.
Nitpick: put each field on its own line, like this:
Some(TypeTemplateArgIterator {
x: self.x,
length: n as u32,
index: 0,
})
jeanphilippeD
force-pushed
the
issue136
branch
from
f6a2003 to
c8c2bdb
Compare
|
@bors-servo r=fitzgen,emilio |
|
📌 Commit c8c2bdb has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 1, 2016
clang::Type::template_args return Option<TypeTemplateArgIterator> Fix #136 by providing a bound checked iterator replacing the interface.
|
Thanks again, this is awesome :) |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #136 by providing a bound checked iterator replacing the interface.