Be less noisy about known to be unimportant errors. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo delegate=fitzgen |
|
✌️ @fitzgen can now approve this pull request |
fitzgen
approved these changes
Oct 31, 2016
| // If the type name is empty we're probably | ||
| // over-recursing to find a template parameter name | ||
| // or something like that, so just don't be too | ||
| // noisy with it sine it causes confusion, see for |
|
@emilio just that typo needs to be fixed, otherwise r+ |
|
@bors-servo r=fitzgen |
|
📌 Commit efb05d5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 31, 2016
Be less noisy about known to be unimportant errors. r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @fitzgen