Run test in parallel batches #167
Conversation
|
I was having a try at implementing this, most of this code is new to me Follow review suggestion to use chunks to run test in parallel. To run with a different batch size: On my machine: |
|
|
||
| let batch_size = env::var("BINDGEN_TEST_BATCH_SIZE") | ||
| .ok() | ||
| .map(|x| x.parse::<usize>().ok()) |
There was a problem hiding this comment.
nit: use and_then here and you'll save the following unwrap_or(None).
| .ok() | ||
| .map(|x| x.parse::<usize>().ok()) | ||
| .unwrap_or(None) | ||
| .unwrap_or(16); |
There was a problem hiding this comment.
Could you move this number to a constant at the top of the file?
| let passed = child.wait() | ||
| .expect("Should wait on child process") | ||
| .success(); | ||
|
|
||
| if passed { None } else { Some((path, child)) } | ||
| }) | ||
| .collect(); | ||
| }) | ||
| .flat_map(|x| x ) |
There was a problem hiding this comment.
use flat_map above (children.flat_map(), and you can remove this line.
Follow review suggestion to use chunks to run test in parallel. Set default to 16 which works well even on my limited laptop, and which should benefit better machine. To run with a different batch size: BINDGEN_TEST_BATCH_SIZE=32 cargo test On my machine: 1 parallel test takes 3'53 2 parallel test takes 2'10 8 parallel test takes 2'08 32 parallel test takes 2'07
jeanphilippeD
force-pushed
the
chunked_parallel_test
branch
from
8a86e88 to
0762243
Compare
|
Thank you very much for your comments, they were very helpful. |
|
@bors-servo r=emilio |
|
📌 Commit 0762243 has been approved by |
Run test in parallel batches
|
☀️ Test successful - status-travis |
No description provided.