Change clang::Type::num_elements to return Option #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emilio
reviewed
Oct 29, 2016
| @@ -673,7 +673,7 @@ impl Type { | |||
| CXType_ConstantArray => { | |||
| let inner = Item::from_ty(&ty.elem_type(), location, parent_id, ctx) | |||
| .expect("Not able to resolve array element?"); | |||
| TypeKind::Array(inner, ty.num_elements()) | |||
| TypeKind::Array(inner, ty.num_elements().expect("Not an array?")) | |||
There was a problem hiding this comment.
Please use unwrap(), if this eventually fails, it's easy to trace it through gdb, and we expect this to be infallible.
Thanks!
|
@catdesk Can you squash your commits? I think it's good to land after squashing. |
|
@bors-servo r+ |
|
📌 Commit 7dac420 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 30, 2016
Change clang::Type::num_elements to return Option Fixes #139.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139.