#144 Changed clang::TranslationUnit::parse to return an Option
#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, looks like tests pass on Travis CI, so I'm not sure what you were seeing locally. |
|
r? @emilio |
|
Thanks a ton for this! @bors-servo: r+ |
|
📌 Commit 362eac2 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Oct 27, 2016
Changed the potentially null pointer to an Optional. The caller previously assumed the pointer was always valid and not null, so I called `expect` to make it fail early if it isn't. Fixes #144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the potentially null pointer to an Optional.
The caller previously assumed the pointer was always valid and not null, so I called
expectto make it fail early if it isn't.Fixes #144.