Add source annotation to express explicit derives for a type. #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for explicit selection of which traits are derived for a
type, e.g. deriving custom traits on particular types that need it.
Example usage:
```C++
/// <div rustbindgen derive="Clone"></div>
/// <div rustbindgen derive="MyDerivableTrait"></div>
struct foo { ... };
```
generates into
```Rust
#[derive(Clone,MyDerivableTrait)]
struct foo { ... }
```
|
|
emilio
approved these changes
Nov 30, 2018
| @@ -1764,6 +1764,8 @@ impl CodeGenerator for CompInfo { | |||
| derives.push("Eq"); | |||
| } | |||
|
|
|||
| derives.extend(item.annotations().derives().iter().map(String::as_str)); | |||
There was a problem hiding this comment.
Maybe they should be deduplicated?
|
Thanks for the patch, and sorry for the slight lag! @bors-servo r+
|
|
Blerg, looks like it is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for explicit selection of which traits are derived for a
type, e.g. deriving custom traits on particular types that need it.
Example usage:
generates into
...as a bit more of an explanation, this is a patch that I've been running bindgen with for a few months to have the ability to run custom derives on types, and more generally be explicit in exactly which derives are applied to a type.
I'm not sure how you feel about PRs out of the blue like this, and if you're looking for a more designed solution then I totally understand I would love to help! (e.g. a command-line or Builder way of specifying derives as well.)