Add #[must_use] to functions annotated with __attribute__((warn_unused_result)) #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
|
|
emilio
approved these changes
Nov 27, 2018
src/ir/function.rs
Outdated
| @@ -387,6 +392,24 @@ impl FunctionSig { | |||
| } | |||
| }; | |||
|
|
|||
| let mut must_use = false; | |||
There was a problem hiding this comment.
Could you move all this block to a function in clang.rs, probably a method of cursor?
Something like the following maybe:
pub fn has_simple_attr(&self, attr: &str) -> bool;Then this code could just be:
let must_use = cursor.has_simple_attribute("warn_unused_result");WDYT?
src/ir/function.rs
Outdated
| abi: Abi, | ||
| ) -> Self { | ||
| FunctionSig { | ||
| return_type: return_type, | ||
| argument_types: arguments, | ||
| is_variadic: is_variadic, | ||
| must_use: must_use, |
There was a problem hiding this comment.
I know it's pre-existing, but if you want this can just be must_use, (same for the other members).
|
Alright, pushed some changes to address your comments. Thanks for the quick review! |
emilio
approved these changes
Nov 27, 2018
| return_type, | ||
| argument_types, | ||
| is_variadic, | ||
| must_use, | ||
| abi: abi, |
There was a problem hiding this comment.
nit: Could've done this for abi as well, but no big deal in any case :)
|
@bors-servo r+ |
|
Ah, forgot bors is still dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at implementing #1450. Take a look at the tests to see the behavior difference on rustc 1.27.
r? @emilio