A better fix for the calling convention madness. #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just realized that we don't really check for this but that clang does.
Seems like a better fix, which allows us to preserve typedefs properly, and also to find the calling convention. Fixes rust-lang#1402.
|
|
|
r? @fitzgen |
fitzgen
approved these changes
Sep 27, 2018
| if opt.starts_with("--target=") { | ||
| let mut split = opt.split('='); | ||
| split.next(); | ||
| return (split.next().unwrap().to_owned(), true); | ||
| } | ||
|
|
||
| if opt == "-target" { |
There was a problem hiding this comment.
$ clang --target foo
clang-6.0: error: unsupported option '--target'
So i think not.
|
@bors-servo r=fitzgen |
|
📌 Commit c75b62d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 28, 2018
A better fix for the calling convention madness. See the commit message for details.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details.