ir: Preserve better whitespace in comments. #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @upsuper |
|
I don't have enough confidence reviewing this... r? @fitzgen |
|
@bors-servo r=fitzgen |
|
📌 Commit 7ad57a4 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 13, 2018
ir: Preserve better whitespace in comments. Fixes #1341.
|
☀️ Test successful - status-travis |
emilio
added a commit
to servo/mozjs
that referenced
this pull request
Oct 29, 2018
rust-lang/rust-bindgen#1384 makes bindgen respect whitespace in documentation comments instead of trimming them. This means that some of the comments from the C++ examples try to get compiled as Rust, with a bad result for `cargo test`s purposes. Just test using cargo test --lib. An alternative would be to disable doc comments in bindgen.
emilio
added a commit
to servo/mozjs
that referenced
this pull request
Oct 29, 2018
rust-lang/rust-bindgen#1384 makes bindgen respect whitespace in documentation comments instead of trimming them. This means that some of the comments from the C++ examples try to get compiled as Rust, with a bad result for `cargo test`s purposes. Just test using cargo test --lib. An alternative would be to disable doc comments in bindgen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1341.