Skip to content

Improve error message when libclang fails #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2018
Merged

Improve error message when libclang fails #1354

merged 1 commit into from
Jul 30, 2018

Conversation

joshlf
Copy link
Contributor

@joshlf joshlf commented Jul 30, 2018

Partially addresses #1331.

@emilio
Copy link
Contributor

emilio commented Jul 30, 2018

Merging manually since CI is busted because rustc-ap-syntax doesn't build. But looks fine otherwise. Thanks for doing this!

@emilio emilio merged commit 0897443 into rust-lang:master Jul 30, 2018
@joshlf
Copy link
Contributor Author

joshlf commented Jul 31, 2018

np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshlf @emilio @highfive