Add an option to set the default codegen style for all enums #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Jun 4, 2018
src/lib.rs
Outdated
| codegen::EnumVariation::Consts => "consts", | ||
| codegen::EnumVariation::ModuleConsts => "moduleconsts", | ||
| }.into()) | ||
| }; |
There was a problem hiding this comment.
nit: No need for this semicolon.
src/codegen/mod.rs
Outdated
|
|
||
| /// Create a `EnumVariation` from a string. | ||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| match s.as_ref() { |
There was a problem hiding this comment.
nit: no need for as_ref I'm pretty sure.
src/lib.rs
Outdated
| @@ -730,6 +741,12 @@ impl Builder { | |||
| } | |||
|
|
|||
|
|
|||
| /// Set the default type of code to generate for enums | |||
| pub fn default_enum_variant(mut self, arg: codegen::EnumVariation) -> Builder { | |||
| self.options.default_enum_variant = arg; | |||
There was a problem hiding this comment.
nit: Maybe call this default_enum_variation? An enum variant is a totally different thing.
|
@bors-servo r+ Thanks! |
|
📌 Commit 393e779 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 4, 2018
Add an option to set the default codegen style for all enums
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.