Skip to content

Add an option to extend the compiled code after each reducing step #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2018

Conversation

db48x
Copy link
Contributor

@db48x db48x commented Jun 3, 2018

This let me add a test function which called a method in the reduced
code, preventing creduce from eliminating everything entirely.

This let me add a test function which called a method in the reduced
code, preventing creduce from eliminating everything entirely.
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

reducing.add_argument(
"--extra-compile-file",
type=str,
help="")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth writing a comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I'd forgotten about that.

@emilio
Copy link
Contributor

emilio commented Jun 3, 2018

@bors-servo r+

@bors-servo
Copy link

📌 Commit c9badcd has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit c9badcd with merge cfd0fa5...

bors-servo pushed a commit that referenced this pull request Jun 3, 2018
Add an option to extend the compiled code after each reducing step

This let me add a test function which called a method in the reduced
code, preventing creduce from eliminating everything entirely.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing cfd0fa5 to master...

@bors-servo bors-servo merged commit c9badcd into rust-lang:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants