ir: Fix wrong condition in bitfield alignment. #1326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should also align the allocation unit even if it's the first bitfield in the allocation unit. Fixes rust-lang#1314
|
|
|
r? @fitzgen |
|
This is not quite right (fixes the layout, but we still look at the wrong offset)... |
|
Oh, we look at the wrong offset in the other test-case... |
|
Is this ready for review? It isn't clear to me and CI is failing. |
|
I need to decide which of the two cases I break, or move all our layout tracking to the time before we compute bitfields... :( |
|
Closing for inactivity, fixing this properly is pretty hard too (and I don't have time to work on it atm). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also align the allocation unit even if it's the first bitfield in the
allocation unit.
Fixes #1314