Skip to content

ir: Remove an assertion that happens to be invalid. #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 31, 2018

You can define a struct declared in an outer scope inside another struct.

C, what a language.

Fixes #1281

You can define a struct declared in an outer scope inside another struct, and
the compiler won't even complain...

C, what a language.

Fixes rust-lang#1281
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor Author

emilio commented Mar 31, 2018

r? @fitzgen or @pepyakin

@pepyakin
Copy link
Contributor

pepyakin commented Apr 2, 2018

@bors-servo r+

:D

@bors-servo
Copy link

📌 Commit d31ed35 has been approved by pepyakin

@bors-servo
Copy link

⌛ Testing commit d31ed35 with merge fb7e519...

bors-servo pushed a commit that referenced this pull request Apr 2, 2018
ir: Remove an assertion that happens to be invalid.

You can define a struct declared in an outer scope inside another struct.

C, what a language.

Fixes #1281
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: pepyakin
Pushing fb7e519 to master...

@bors-servo bors-servo merged commit d31ed35 into rust-lang:master Apr 2, 2018
@fitzgen
Copy link
Member

fitzgen commented Apr 3, 2018

wat o_O

@emilio emilio deleted the what-a-language branch April 8, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants