Declare precedence on enum types #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an enum matched a pattern for rustified enum and constified module enum, then rust code would fail to compile with "ambiguous associated type" error. We fix the error by giving constified module enum "higher precedence". Fixes issue rust-lang#1198
emilio
reviewed
Mar 13, 2018
| @@ -0,0 +1,18 @@ | |||
| /* automatically generated by rust-bindgen */ | |||
|
|
|||
| #![allow(dead_code, non_snake_case, non_camel_case_types, non_upper_case_globals)] | |||
There was a problem hiding this comment.
Looks like CI is not really happy about this (needs expectations for other libclang versions). But does this need to be really a libclang-3.9+ test?
|
@bors-servo r+ Thanks! |
|
📌 Commit 8c9b3ab has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 13, 2018
Declare precedence on enum types Fixes issue #1198 where an enum matches the pattern for multiple enum types, such as constified module enum AND rustified enum. Documents precedence in `Builder` doc comment.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1198 where an enum matches the pattern for multiple enum types, such as constified module enum AND rustified enum.
Documents precedence in
Builderdoc comment.