Fix missing dylibs #1256
Merged
Fix missing dylibs #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Feb 14, 2018
This reverts commit 6899c27. The `proc_macro2` crate depends on rustc internal crates, which means that `bindgen` would need to be run under `rustup`. We can follow rust-lang/rust#47931 to get updates on when this issue might be resolved and we can update `quote` again. Fixes rust-lang#1248
fitzgen
force-pushed
the
fix-missing-dylibs
branch
from
8bb7a75 to
ad6b223
Compare
|
Added to the commit message. Thanks @emilio ! @bors-servo r+ |
|
📌 Commit ad6b223 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 14, 2018
Fix missing dylibs r? @emilio
|
💔 Test failed - status-travis |
|
Failures are flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @emilio