Skip to content

ir: Choose the right mangling for destructors on all codepaths. #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 29, 2018

Fixes #1133.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor Author

emilio commented Jan 29, 2018

r? @fitzgen or @pepyakin

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- thanks!

@fitzgen
Copy link
Member

fitzgen commented Jan 29, 2018

@bors-servo r+

@bors-servo
Copy link

📌 Commit 29705c2 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 29705c2 with merge 6adb002...

bors-servo pushed a commit that referenced this pull request Jan 29, 2018
ir: Choose the right mangling for destructors on all codepaths.

Fixes #1133.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 6adb002 to master...

@bors-servo bors-servo merged commit 29705c2 into rust-lang:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants