Support str as input to Builder::no_* functions #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only String was supported on these while other functions in Builder worked with both str and String
|
@bors-servo r+ |
|
📌 Commit 8afc763 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 28, 2018
Support str as input to Builder::no_* functions Previously, only String was supported on these while other functions in Builder worked with both str and String This tripped me up because `Builder::constified_enum_module` and `Builder::raw_line` worked with string slices but I got a compile error when I tried to use `Builder:;no_copy`
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only String was supported on these while other functions in Builder worked with both str and String
This tripped me up because
Builder::constified_enum_moduleandBuilder::raw_lineworked with string slices but I got a compile error when I tried to useBuilder:;no_copy