Skip to content

lib: Add a way to override rustfmt path. #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2018

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 26, 2018

I'll need it to format some stuff on mozilla-central.

src/lib.rs Outdated
@@ -601,6 +601,12 @@ impl Builder {
self
}

/// Sets an explicit path to rustfmt, to use when rustfmt is enabled.
pub fn with_rustfmt<P: Into<PathBuf>>(mut self, path: P) -> Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this next to the other rustfmt related methods/options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done!

I'll need it to format some stuff on mozilla-central.
@emilio
Copy link
Contributor Author

emilio commented Jan 26, 2018

@bors-servo r=fitzgen

@bors-servo
Copy link

📌 Commit 417c6d1 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 417c6d1 with merge cc909e5...

bors-servo pushed a commit that referenced this pull request Jan 26, 2018
lib: Add a way to override rustfmt path.

I'll need it to format some stuff on mozilla-central.
@bors-servo
Copy link

💔 Test failed - status-travis

@emilio
Copy link
Contributor Author

emilio commented Jan 26, 2018

@bors-servo r=fitzgen

  • Always forget to update the lockfile.

@bors-servo
Copy link

📌 Commit b16e09c has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit b16e09c with merge 4d1c954...

bors-servo pushed a commit that referenced this pull request Jan 26, 2018
lib: Add a way to override rustfmt path.

I'll need it to format some stuff on mozilla-central.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 4d1c954 to master...

@bors-servo bors-servo merged commit b16e09c into rust-lang:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants